--- trunk/run.pl 2006/10/05 14:46:38 738 +++ trunk/run.pl 2006/11/03 20:21:09 769 @@ -7,9 +7,9 @@ use lib './lib'; use WebPAC::Common 0.02; -use WebPAC::Parser 0.07; -use WebPAC::Input 0.13; -use WebPAC::Store 0.11; +use WebPAC::Parser 0.08; +use WebPAC::Input 0.14; +use WebPAC::Store 0.14; use WebPAC::Normalize 0.22; use WebPAC::Output::TT; use WebPAC::Validate 0.06; @@ -153,8 +153,9 @@ my $use_indexer = $config->use_indexer; +$stats ||= $validate; if ($stats) { - $log->debug("option --stats disables update of indexing engine..."); + $log->debug("disabled indexing for stats collection"); $use_indexer = undef; } else { $log->info("using $use_indexer indexing engine..."); @@ -198,7 +199,7 @@ } my $indexer; - if ($use_indexer) { + if ($use_indexer && $parser->have_rules( 'search', $database )) { my $cfg_name = $use_indexer; $cfg_name =~ s/\-.*$//; @@ -350,13 +351,6 @@ my $rec = shift || die "need rec!"; my $mfn = $rec->{'000'}->[0] || die "need mfn in 000"; - $store->save_row( - database => $database, - input => $input_name, - id => $mfn, - row => $rec, - ); - WebPAC::Normalize::data_structure( row => $rec, rules => $rules, @@ -380,12 +374,30 @@ lookup_coderef => $lookup_coderef, lookup => $lookup_jar, %{ $input }, + load_row => sub { + my $a = shift; + return $store->load_row( + database => $database, + input => $input_name, + id => $a->{id}, + ); + }, + save_row => sub { + my $a = shift; + return $store->save_row( + database => $database, + input => $input_name, + id => $a->{id}, + row => $a->{row}, + ); + }, + ); my $lookup_data = WebPAC::Normalize::_get_lookup(); if (defined( $lookup_data->{$database}->{$input_name} )) { - $log->debug("created following lookups: ", dump( $lookup_data )); + $log->debug("created following lookups: ", sub { dump( $lookup_data ) } ); foreach my $key (keys %{ $lookup_data->{$database}->{$input_name} }) { $store->save_lookup( @@ -408,7 +420,7 @@ } my $marc; - if ($parser->generate_marc( $database, $input_name )) { + if ($parser->have_rules( 'marc', $database, $input_name )) { $marc = new WebPAC::Output::MARC( path => "out/marc/${database}-${input_name}.marc", lint => $marc_lint, @@ -436,17 +448,19 @@ foreach my $db (keys %$depends) { foreach my $i (keys %{$depends->{$db}}) { foreach my $k (keys %{$depends->{$db}->{$i}}) { + my $t = time(); $log->debug("loading lookup $db/$i"); $lookup_hash->{$db}->{$i}->{$k} = $store->load_lookup( database => $db, input => $i, key => $k, ); + $log->debug(sprintf("lookup $db/$i took %.2fs", time() - $t)); } } } - $log->debug("lookup_hash = ", dump( $lookup_hash )); + $log->debug("lookup_hash = ", sub { dump( $lookup_hash ) }); } @@ -454,6 +468,8 @@ my $row = $input_db->fetch || next; + $total_rows++; + my $mfn = $row->{'000'}->[0]; if (! $mfn || $mfn !~ m#^\d+$#) { @@ -464,11 +480,12 @@ if ($validate) { - if ( my $errors = $validate->validate_errors( $row, $input_db->dump ) ) { + if ( my $errors = $validate->validate_rec( $row, $input_db->dump ) ) { $log->error( "MFN $mfn validation error:\n", $validate->report_error( $errors ) ); } + next; # validation doesn't create any output } my $ds = WebPAC::Normalize::data_structure( @@ -487,7 +504,7 @@ }, ); - $log->debug("ds = ",dump($ds)); + $log->debug("ds = ", sub { dump($ds) }) if ($ds); $store->save_ds( database => $database, @@ -517,8 +534,6 @@ $log->info("Created $i instances of MFN $mfn\n") if ($i > 1); } - - $total_rows++; } if ($validate) {