--- trunk/vz-clone.pl	2007/10/05 01:01:13	29
+++ trunk/vz-clone.pl	2009/03/09 19:04:19	73
@@ -1,20 +1,20 @@
 #!/usr/bin/perl -w
 
 use strict;
-use Shell qw/rsync vzlist lvcreate mount umount lvremove which lvdisplay mke2fs vzctl/;
+use Shell qw/rsync lvcreate mount umount lvremove which lvdisplay mke2fs/;
 
-my $vz   = '/vz';
-my $conf = '/etc/vz/conf';
+use lib 'lib';
+use VZ;
 
-my $snap_size = '100M';
+my $snap_size = '10G';
 
 my ( $action, $VEID ) = @ARGV;
 
-my $use_snapshot = 0;
+my $use_snapshot = 1;
 
 my $valid_actions = 'create|mount|umount|destroy';
 
-die "Usage: $0 ($valid_actions) VEID\n\n",vzlist unless $VEID && $action && $action =~ m/($valid_actions)/;
+die "Usage: $0 ($valid_actions) VEID\n\n",`vzlist` unless $VEID && $action && $action =~ m{($valid_actions)};
 
 my $CVEID = "10$VEID";
 
@@ -27,7 +27,6 @@
 	}
 }
 
-
 if ( $action eq 'create' ) {
 	vzctl_stop( $CVEID );
 } elsif ( $action eq 'destroy' ) {
@@ -35,22 +34,31 @@
 }
 
 
-if ( 1 || $action =~ m/(umount|destroy)/ ) {
+if ( $action =~ m{(create|umount|destroy)} ) {
 	my $clone;
+	my $snap;
 	open(my $m, '-|', 'mount') || die "can't open mount: $!";
 	while(<$m>) {
 		my @v = split(/\s+/,$_);
-		if ( $v[2] =~ m!/(private|root)/$VEID$! && $v[5] =~ m/bind/ ) {
+		if ( $v[2] =~ m{/(private|root)/($VEID|$CVEID)$} && $v[5] =~ m{bind} ) {
 			umount( $v[2] );
-		} elsif ( $v[2] =~ m!vz-clone-$VEID$! ) {
+		} elsif ( $v[2] =~ m{vz-clone-$CVEID$} ) {
 			$clone = $v[2];
+		} elsif ( $v[2] =~ m{-snap} ) {
+			$snap = $v[0];
+			umount( $snap );
 		}
 	}
 	umount( $clone ) if $clone;
+	if ( $action eq 'destroy' && -e $snap ) {
+		lvremove( '-f', $snap );
+	}
+
+	vzctl('destroy', $VEID) if $action eq 'destroy';
+
+	exit if $action =~ m{(umount|destroy)};
 }
 
-#die "unknown action: $action" unless $action eq 'create';
-exit unless $action =~ m/(create|mount)/;
 
 my $orig_conf = "/etc/vz/conf/$VEID.conf";
 
@@ -60,15 +68,13 @@
 
 my $vz_lv;
 
-open(my $m, '<', '/etc/fstab') || die "can't open /etc/fstab: $!";
+open(my $m, '-|', "df $vz_root") || die "can't open df $vz_root: $!";
 while(<$m>) {
-	next if m/^#/;
+	next if ! m{^/};
 	my @v = split(/\s+/,$_);
-	if ( $v[1] =~ m/\Q$vz\E/ ) {
-		$vz_lv = $v[0];
-		warn "found LV $vz_lv for $vz\n";
-		last;
-	}
+	$vz_lv = $v[0];
+	warn "found LV $vz_lv for $vz_root\n";
+	last;
 }
 
 sub fs_quota {
@@ -86,12 +92,12 @@
 	my ( $from, $to ) = @_;
 	return if $action ne 'create';
 	warn "rsync $from -> $to\n";
-	rsync('-raSHAD', "$from/", "$to/" );
+	rsync('-raSHAD', '--delete', "$from/", "$to/" );
 }
 
 if ( $vz_lv ) {
 
-	my ( $vz_lv_path, $vz_lv_name ) = ( $1, $2 ) if ( $vz_lv =~ m!^(.+)/([^/]+)$! );
+	my ( $vz_lv_path, $vz_lv_name ) = ( $1, $2 ) if ( $vz_lv =~ m{^(.+)/([^/]+)$} );
 
 	my $snap = $vz_lv_name . '-snap';
 	my $clone = "vz-clone-$CVEID";
@@ -124,57 +130,51 @@
 
 		do_mount( "$vz_lv_path/$snap", "/tmp/$snap" );
 	
-	}
-
-	my $vg_name = $1 if ( $vz_lv_path =~ m!/([^/]+)/*$! );
+		mount_bind( "/tmp/$snap/private/$VEID", "$vz_root/private/$CVEID" );
+		mount_bind( "/tmp/$snap/root/$VEID", "$vz_root/root/$CVEID" );
 
-	if ( lvdisplay( "$vz_lv_path/$clone" ) ) {
-		warn "using existing $vz_lv_path/$clone\n";
 	} else {
-		my $clone_size = fs_quota( $VEID ) . 'k';
-		print "Creating LV $clone ($clone_size bytes) in VG $vg_name for $VEID clone filesystem\n";
-		lvcreate( '--size', $clone_size, '--name', $clone, $vg_name );
-		mke2fs( '-m', 0, '-j', "$vz_lv_path/$clone" );
-	}
-
-	do_mount( "$vz_lv_path/$clone", "/tmp/$clone" );
 
-	test_mkdir( "/tmp/$clone/private" );
-	test_mkdir( "/tmp/$clone/root" );
-
-	mount_bind( "/tmp/$clone/private", "$vz/private/$CVEID" );
-	mount_bind( "/tmp/$clone/root", "$vz/root/$CVEID" );
-
-	if ( $use_snapshot ) {
+		if ( lvdisplay( "$vz_lv_path/$clone" ) ) {
+			warn "using existing $vz_lv_path/$clone\n";
+		} else {
+			my $vg_name = $1 if ( $vz_lv_path =~ m{/([^/]+)/*$} );
+			my $clone_size = fs_quota( $VEID ) . 'k';
+			print "Creating LV $clone ($clone_size bytes) in VG $vg_name for $VEID clone filesystem\n";
+			lvcreate( '--size', $clone_size, '--name', $clone, $vg_name );
+			mke2fs( '-m', 0, '-j', "$vz_lv_path/$clone" );
+		}
 
-		copy_files( "/tmp/$snap/private/$VEID", "/tmp/$clone/private" );
+		do_mount( "$vz_lv_path/$clone", "/tmp/$clone" );
 
-		print "Cleanup\n";
+		test_mkdir( "/tmp/$clone/private" );
+		test_mkdir( "/tmp/$clone/root" );
 
-		#umount( "$vz_lv_path/$clone" );
-		umount( "$vz_lv_path/$snap" );
+		copy_files( "$vz_root/private/$VEID", "/tmp/$clone/private" );
 
-		lvremove( '-f', "$vz_lv_path/$snap" );
-
-	} else {
-		copy_files( "$vz/private/$VEID", "/tmp/$clone/private" );
+		mount_bind( "/tmp/$clone/private", "$vz_root/private/$CVEID" );
+		mount_bind( "/tmp/$clone/root", "$vz_root/root/$CVEID" );
 
 	}
 
 } else {
 
-	copy_files( "$vz/private/$VEID", "$vz/private/$CVEID" );
+	copy_files( "$vz_root/private/$VEID", "$vz_root/private/$CVEID" );
 }
 
 exit if $action eq 'mount';
 
 my $note = "# modified by $0\n";
 
+my $ve_clone_ip;
+
 sub fix_ip {
 	my $ip = shift;
 	$ip =~ s/['"]//g;
-	$ip =~ s/^\d+\./10./;
+#	$ip =~ s/^\d+\./10./;
+	$ip =~ s/^\d+\.\d+\./192.168./;
 	warn "$CVEID new IP number: $ip\n";
+	$ve_clone_ip = $ip;
 	return $note . qq{IP_ADDRESS="$ip"};
 }
 
@@ -186,13 +186,18 @@
 	return $note . qq{HOSTNAME="$hostname"};
 }
 
-open(my $o, '<', "$conf/$VEID.conf")  || die "can't open $conf/$VEID.conf: $!";
-open(my $n, '>', "$conf/$CVEID.conf") || die "can't open $conf/$CVEID.conf: $!";
+open(my $o, '<', "$vz_conf/$VEID.conf")  || die "can't open $vz_conf/$VEID.conf: $!";
+open(my $n, '>', "$vz_conf/$CVEID.conf") || die "can't open $vz_conf/$CVEID.conf: $!";
 while(<$o>) {
-	s!^HOSTNAME=(.*)$!fix_hostname($1)!ie;
-	s!^IP_ADDRESS=(.*)$!fix_ip($1)!ie;
-	s!^(ONBOOT=).*$!# modified by $0\n$1"no"!i;
+	s{^HOSTNAME=(.*)$}{fix_hostname($1)}ie;
+	s{^IP_ADDRESS=(.*)$}{fix_ip($1)}ie;
+	s{^(ONBOOT=).*$}{# modified by $0\n$1"no"}i;
 	print $n $_;
 }
 
-print "\nPlease review config file: $conf/$CVEID.conf\nAdd NAT for new VE with: iptables -t nat -A POSTROUTING -o eth0 -j MASQUERADE\nStart clone of $VEID with: vzctl start $CVEID\n"
+print $n qq{DISK_QUOTA="no"\n} if $use_snapshot; # don't wait for quota rebuild on startup
+
+my $iptables="iptables -t nat -A POSTROUTING -s $ve_clone_ip -o eth0 -j MASQUERADE";
+system( $iptables );
+print "\nConfig file: $vz_conf/$CVEID.conf\nAdded NAT for new VE with: $iptables\nStart clone of $VEID with: vzctl start $CVEID\n"
+