--- trunk/pgswish.c 2005/02/19 11:39:11 10 +++ trunk/pgswish.c 2005/05/29 20:30:18 20 @@ -6,6 +6,8 @@ * TODO: * - check null input using PG_ARGISNULL before using PG_GETARG_xxxx * - support composite type arguments + * - split error_or_abort + * - use getResultPropValue not SwishResultPropertyStr * * NOTES: * - clear structures with memset to support hash indexes (who whould like @@ -25,15 +27,20 @@ #include "fmgr.h" #include "funcapi.h" #include "utils/builtins.h" +#include "utils/array.h" +#include "miscadmin.h" #include #define _textin(str) DirectFunctionCall1(textin, CStringGetDatum(str)) #define _textout(str) DatumGetPointer(DirectFunctionCall1(textout, PointerGetDatum(str))) +#define GET_STR(textp) DatumGetCString(DirectFunctionCall1(textout, PointerGetDatum(textp))) +#define GET_TEXT(cstrp) DatumGetTextP(DirectFunctionCall1(textin, CStringGetDatum(cstrp))) - -SW_HANDLE swish_handle = NULL;/* Database handle */ -SW_SEARCH search = NULL; /* search handle -- holds search parameters */ -SW_RESULTS results = NULL; /* results handle -- holds list of results */ +/* Globals */ +static SW_HANDLE swish_handle = NULL; /* Database handle */ +static SW_SEARCH search = NULL; /* search handle -- search parameters */ +static SW_RESULTS swish_results = NULL; /* results handle -- list of results */ +static SW_RESULT *sw_res = NULL; /* one row from swish-e results */ /* define PostgreSQL v1 function */ PG_FUNCTION_INFO_V1(pgswish); @@ -45,11 +52,9 @@ TupleDesc tupdesc; TupleTableSlot *slot; AttInMetadata *attinmeta; - SW_HANDLE swish_handle = NULL; /* Database handle */ - SW_SEARCH search = NULL; /* search handle -- holds search parameters */ - SW_RESULTS results = NULL; /* results handle -- holds list of results */ char *index_path; char *query; + FILE *logfh; /* stuff done only on the first call of the function */ if (SRF_IS_FIRSTCALL()) { @@ -67,33 +72,44 @@ oldcontext = MemoryContextSwitchTo(funcctx->multi_call_memory_ctx); - /* Send any errors or warnings to stderr (default is stdout) */ - SwishErrorsToStderr(); + /* Send any errors or warnings to log, as well as + * STDOUT and STDERR (just to be sure) */ + if ( logfh = fopen("/tmp/pgswish.log", "a") ) { + set_error_handle( logfh ); + elog(INFO, "loggin swish-e errors to /tmp/pgswish.log"); + /* redirect STDOUT and STDERR to log */ + dup2(1, logfh); + dup2(2, logfh); + } else { + elog(INFO, "can't open /tmp/pgswish.log -- errors from swish-e won't be cought and may result in back-end crashes!"); + } elog(INFO, "pgswish: SwishInit(%s)", index_path); - + swish_handle = SwishInit( index_path ); + if ( SwishError( swish_handle ) ) + elog(INFO, "pgswish: SwishInit(%s) failed: %s", index_path, SwishErrorString( swish_handle )); + + elog(INFO, "handle: %08x", swish_handle); + if (! swish_handle) { elog(ERROR, "pgswish: can't open %s", index_path); SRF_RETURN_DONE(funcctx); } - if ( SwishError( swish_handle ) ) error_or_abort( swish_handle ); + if (error_or_abort( swish_handle )) SRF_RETURN_DONE(funcctx); /* set ranking scheme. default is 0 */ SwishRankScheme( swish_handle, 0 ); - - /* Check for errors after every call */ - if ( SwishError( swish_handle ) ) - error_or_abort( swish_handle ); /* print an error or abort -- see below */ + if (error_or_abort( swish_handle )) SRF_RETURN_DONE(funcctx); elog(INFO, "pgswish: SwishQuery(%s)", query); /* Here's a short-cut to searching that creates a search object and searches at the same time */ - results = SwishQuery( swish_handle, query); - if ( SwishError( swish_handle ) ) error_or_abort( swish_handle ); + swish_results = SwishQuery( swish_handle, query); + if (error_or_abort( swish_handle )) SRF_RETURN_DONE(funcctx); /* total number of tuples to be returned */ - funcctx->max_calls = SwishHits( results ); + funcctx->max_calls = SwishHits( swish_results ); /* check if results exists */ if ( 0 == funcctx->max_calls ) @@ -118,6 +134,8 @@ funcctx->attinmeta = attinmeta; MemoryContextSwitchTo(oldcontext); + + elog(INFO, "SRF_IS_FIRSTCALL done"); } /* stuff done on every call of the function */ @@ -133,18 +151,58 @@ HeapTuple tuple; Datum result; -if (0) { + elog(INFO, "pgswish: loop count %d", call_cntr); + + if (! swish_results) { + elog(ERROR, "pgswish: no swish-e results"); + SRF_RETURN_DONE(funcctx); + } + + elog(DEBUG1, "pgswish: check for swish-e error"); + if (error_or_abort( swish_handle )) SRF_RETURN_DONE(funcctx); + /* * Prepare a values array for storage in our slot. * This should be an array of C strings which will * be processed later by the type input functions. */ - values = (char **) palloc(5 * sizeof(char *)); - values[0] = _textout( SwishResultPropertyULong ( result, "swishrank" ) ); - values[1] = _textout( SwishResultPropertyStr ( result, "swishdocpath" ) ); - values[2] = _textout( SwishResultPropertyStr ( result, "swishtitle" ) ); - values[3] = _textout( SwishResultPropertyStr ( result, "swishdocsize" ) ); - values[4] = _textout( SwishResultPropertyStr ( result, "swishdbfile" ) ); + + sw_res = SwishNextResult( swish_results ); + if (! sw_res) { + elog(ERROR, "pgswish: swish-e sort result list: %d rows expected %d", call_cntr, max_calls - 1); + Free_Results_Object( swish_results ); + Free_Search_Object( search ); + SRF_RETURN_DONE(funcctx); + } + + elog(INFO, "Path: %s\n Rank: %lu\n Size: %lu\n Title: %s\n Index: %s\n Modified: %s\n Record #: %lu\n File #: %lu\n\n", + SwishResultPropertyStr ( sw_res, "swishdocpath" ), + SwishResultPropertyULong ( sw_res, "swishrank" ), + SwishResultPropertyULong ( sw_res, "swishdocsize" ), + SwishResultPropertyStr ( sw_res, "swishtitle"), + SwishResultPropertyStr ( sw_res, "swishdbfile" ), + SwishResultPropertyStr ( sw_res, "swishlastmodified" ), + SwishResultPropertyULong ( sw_res, "swishreccount" ), /* can figure this out in loop, of course */ + SwishResultPropertyULong ( sw_res, "swishfilenum" ) + ); + + values = (char **) palloc(4 * sizeof(char *)); + + values[0] = prop2int( sw_res, "swishrank" ); + values[1] = prop2text( sw_res, "swishdocpath" ); + values[2] = prop2text( sw_res, "swishtitle" ); + values[3] = prop2int( sw_res, "swishdocsize" ); + +/* + values[0] = (char *) palloc(16 * sizeof(char)); + snprintf(values[0], 16, "%d", 1); + values[1] = (char *) palloc(16 * sizeof(char)); + snprintf(values[1], 16, "%d", 2); + values[2] = (char *) palloc(16 * sizeof(char)); + snprintf(values[2], 16, "%d", 3); + values[3] = (char *) palloc(16 * sizeof(char)); + snprintf(values[3], 16, "%d", 4); +*/ /* build a tuple */ tuple = BuildTupleFromCStrings(attinmeta, values); @@ -152,11 +210,19 @@ /* make the tuple into a datum */ result = TupleGetDatum(slot, tuple); -} - /* clean up (this is not really necessary) */ - + /* clean up ? */ + pfree(values[0]); + pfree(values[1]); + pfree(values[2]); + pfree(values[3]); + pfree(values); + + elog(DEBUG1, "row: %s|%s|%s|%s",values[0],values[1],values[2],values[3]); + SRF_RETURN_NEXT(funcctx, result); } else { + elog(INFO, "loop over"); + /* free swish object and close */ Free_Search_Object( search ); SwishClose( swish_handle ); @@ -166,14 +232,69 @@ } } + +/* make text var from property */ +char *prop2text(SW_RESULT sw_res, char *propname) { + char *val; + char *prop; + int len; + + elog(DEBUG2, "prop2text(%s)", propname); + + prop = SwishResultPropertyStr( sw_res, propname ); + if (error_or_abort( swish_handle )) return NULL; + + len = strlen(prop); + elog(DEBUG1, "prop2text(%s) = '%s' %d bytes", propname, prop, len); + + len++; + len *= sizeof(char); + + elog(DEBUG2, "palloc(%d)", len); + + val = palloc(len); + + memset(val, 0, len); + strncpy(val, prop, len); + + elog(DEBUG2, "val=%s", val); + + return val; +} + +/* make integer variable from property */ +char *prop2int(SW_RESULT sw_res, char *propname) { + char *val; + unsigned long prop; + int len; + + elog(DEBUG2, "prop2int(%s)", propname); + + prop = SwishResultPropertyULong( sw_res, propname ); + if (error_or_abort( swish_handle )) return NULL; + + elog(DEBUG1, "prop2int(%s) = %lu", propname, prop); + + len = 128 * sizeof(char); + elog(DEBUG2, "palloc(%d)", len); + + val = palloc(len); + memset(val, 0, len); + + snprintf(val, len, "%lu", prop); + + elog(DEBUG2, "val=%s", val); + + return val; +} + + /* - * elog errors - * + * check if swish has returned error, and elog it. */ - -static void error_or_abort( SW_HANDLE swish_handle ) { +static int error_or_abort( SW_HANDLE swish_handle ) { if ( !SwishError( swish_handle ) ) - return; + return 0; /* print a message */ elog(ERROR, @@ -182,9 +303,10 @@ SwishErrorString( swish_handle ), SwishLastErrorMsg( swish_handle ) ); + if ( swish_results ) Free_Results_Object( swish_results ); if ( search ) Free_Search_Object( search ); SwishClose( swish_handle ); - /* do when there is no more left */ + return 1; }