--- trunk/lib/Frey/SVN.pm 2008/12/15 20:10:48 851 +++ trunk/lib/Frey/SVN.pm 2009/06/03 18:19:03 1077 @@ -8,10 +8,13 @@ extends 'Frey'; with 'Frey::Web'; -#with 'Frey::Storage'; +with 'Frey::Storage'; +with 'Frey::HTML::Diff'; use XML::Simple; use DateTimeX::Easy; +use Text::Diff::Parser; +use File::Path qw/mkpath/; has repository => ( is => 'rw', @@ -20,12 +23,29 @@ default => 'file:///home/dpavlin/private/svn/Frey', ); +has path => ( + is => 'rw', + isa => 'Str' +); + has limit => ( is => 'rw', isa => 'Int', default => 50, ); +has include_diff => ( + is => 'ro', + isa => 'Bool', + default => 0, +); + +has file_stats => ( + is => 'ro', + isa => 'Bool', + default => 1, +); + sub iterator { my ($self,$coderef) = @_; @@ -48,14 +68,16 @@ return; } - my $path = $self->repository; + my $path = $self->repository . $self->path; warn "# path $path\n"; my $cmd; + my $svn_path = $path; + if ($path =~ m#file://# || -e "$path/.svn") { $cmd = "svn log -v --xml $path"; } else { - my $svn_path = sh_regex('svk info', qr#Mirrored From:\s+([^,]+)#i); + $svn_path = sh_regex('svk info', qr#Mirrored From:\s+([^,]+)#i); if (! $svn_path) { @@ -91,7 +113,47 @@ my $xml = XMLin($log, ForceArray => [ 'logentry', 'path' ]); foreach my $e (@{$xml->{'logentry'}}) { - warn "# e = ",$self->dump( $e ); + warn "# e = ",$self->dump( $e ) if $self->debug; + + if ( $self->include_diff || $self->file_stats ) { + my $rev = $e->{'revision'}; + + $e->{diff_paths}->{rev} = $rev; # XXX debug + + my $cache = $svn_path; + $cache =~ s{^\w+:/+}{}; + $cache = "var/svn/$cache"; + mkpath $cache unless -e $cache; + my $diff_paths = $self->load( "$cache/$rev.yaml" ); + if ( ! $diff_paths ) { + my $cmd = "svn diff -c $rev $svn_path"; + my ( $diff_fh, $diff_out ); + my $diff_file = "$cache/$rev.diff"; + + open($diff_fh, '-|', $cmd) || die "can't open pipe from $cmd: $!"; + open($diff_out,'>' , $diff_file) || die "can't write $diff_file: $!"; + warn "# creating $diff_file from $cmd\n"; + + my $diff_path; + + while( <$diff_fh> ) { + print $diff_out $_; + + if ( m{^\+\+\+ (\S+)} ) { + $diff_path = "/$1"; # subversion paths start with / + } elsif ( m{^\+} && $diff_path ) { + $diff_paths->{$diff_path}->{added}++; + } elsif ( m{^-} && $diff_path ) { + $diff_paths->{$diff_path}->{removed}++; + } + } + + $self->store( "$cache/$rev.yaml", $diff_paths ); + } + $e->{diff} = $self->load( "$cache/$rev.diff" ) if $self->include_diff; + $e->{diff_paths} = $self->load( "$cache/$rev.yaml" ); + } + $coderef->($e); } } @@ -108,17 +170,53 @@ $foo =~ s//>/g; $foo =~ s/"/"/g; - $foo =~ s/([\n\r][\n\r]+)/<\/p>$1

/gis; +# $foo =~ s/([\n\r][\n\r]+)/$1/gis; $foo =~ s/([\n\r]+)([\-\*]\s+)/$1$2/gis; $foo =~ s/([\n\r]+)(r\d+:\s+)/$1$2/gis; $foo =~ s/([\n\r]+)(\s+r\d+@)/$1$2/gis; # svk return $foo; } - our $html = ''; - sub html { - $html .= join("\n", @_); - } + my $repository = $self->repository; + my $path = $self->path; + + our $html = qq| +

$repository

+

$path

+ |; + + $self->add_css(qq| + .commit { + clear: both; + padding-top: 1em; + padding-bottom: 1em; + border-top: 1px dashed #ccc; + } + .files { + color: #888; + font-family: monospace; + font-size: 80%; + float: right; + padding-bottom: 1.2em; /* fix 80% back to original 1em */ + } + .files a { + text-decoration: none; + color: #888; + } + .date, .revision { color: #666; } + .message { + padding-top: 0.5em; + padding-left: 2em; /* like blockquote */ + white-space: pre-wrap; + } + + ins { color: #8c8 } + del { color: #c88 } + |); + + my $max_path_len = 0; + my $path_count; + my $stats; $self->iterator( sub { my $e = shift; @@ -129,7 +227,12 @@ $date =~ s/T/ /; $date =~ s/\.\d+Z$//; - html '

'.$date.' ',$e->{'author'},' r',$e->{'revision'},'

'; + my $msg = $e->{'msg'}; + $msg = '' if ref($msg); # FIXME why do I need this, dammit? + if ( $msg ) { + $msg = encode( $msg ); + $msg = qq|
$msg
|; + } my @files; @@ -143,16 +246,85 @@ } else { push @files, $path; } + + $max_path_len = length $path if length $path > $max_path_len; + $path_count->{$path}++; + + if ( my $added = $e->{diff_paths}->{$path}->{added} ) { + $stats->{total_added} += $added; + } + + if ( my $removed = $e->{diff_paths}->{$path}->{removed} ) { + $stats->{total_removed} += $removed; + } } - my $msg = $e->{'msg'}; - $msg = '' if ref($msg); # FIXME why do I need this, dammit? - $msg = encode( $msg ); + my $diff = $self->html_diff( $e->{diff} ) if $e->{diff}; + + $self->add_css(qq| + .diff-lines { + margin-left: 1em; + float: right; + } + |); - html '

',join(", ",@files),' ',$msg,'

'; + $html .= qq| +
+ $date + $e->{author} + $e->{revision} +
\n + | + . join("
\n", + map { + my $path = $_; + $path =~ s{<[^>]+>}{}g; + my $diff = ''; + if ( $diff = $e->{diff_paths}->{$path} ) { + $diff + = qq|| + . join(" ", + map { + my $v = $diff->{$_}; + s[added][+$v]; + s[removed][-$v]; + $_; + } keys %$diff + ) + . qq|| + ; + warn "DIFF $diff"; + } + + qq|$diff$_| + } @files + ) + . qq| +
+ $msg + $diff +
+ |; }); + $max_path_len += + length( $stats->{total_added} ) + + length( $stats->{total_removed} ) + ; + + $max_path_len += int( $max_path_len / 10 ); # we are using ex, so we add 10% + + $self->add_css(qq| + .files { + width: ${max_path_len}ex; + } + |); + + $html =~ s[title="(\S+) ##"]['title="' . $path_count->{$1} . '"']gse; + + $html .= $self->dump( 'stats', $stats ); + return $html; } @@ -172,7 +344,13 @@ foreach my $p (@{$e->{'paths'}->{'path'}}) { my ($action,$path) = ($p->{'action'},$p->{'content'}); - $file_events .= qq|\t\n|; + my $weight = ''; + if ( my $s = $e->{diff_paths}->{$path} ) { + $weight = $s->{removed} || 0; + $weight += $s->{added} * 2 if $s->{added}; + $weight = qq| weight="$weight" |; + } + $file_events .= qq|\t\n|; } });