--- trunk/lib/Frey/Run.pm	2008/11/19 19:28:09	467
+++ trunk/lib/Frey/Run.pm	2008/11/28 16:39:37	591
@@ -2,8 +2,6 @@
 use Moose;
 #extends 'Frey::ClassLoader';
 extends 'Frey::Action';
-with 'Frey::Web';
-with 'Frey::Escape';
 with 'Frey::Session';
 
 use Data::Dump qw/dump/;
@@ -30,7 +28,7 @@
 
 subtype 'Runnable'
 	=> as 'Str',
-	=> where sub { m{^as_} };
+	=> where sub { m{^as_} || m{_as_} };
 
 sub formats_available { qw/html js json yaml yml/ }
 enum 'Formats' => formats_available;
@@ -67,33 +65,34 @@
 		my $class = $self->class;
 		$self->load_class( $class );
 
-		if ( $body = $self->params_form ) {
+		if ( my $form = $self->params_form ) {
+			$html = $self->page( body => $form );
 			warn "got required params form for $class ", $self->run, " format: ", $self->format;
 		} else {
 
 			$self->usage->{ $class }++;
 
+=begin remove
 			my $o;
 			my ( $meta, $is_role, $instance ) = $self->class_meta( $class );
 			if ( $is_role ) {
 				$o = $instance;
+				if ( $o->can('add_status') ) {
+					$self->TODO("missing add_status in $o");
+					Frey::Web->meta->apply( $o );
+					warn "# apply Frey::Web to $class instance $o";
+				}
 			} else {
 				$o = $self->new_frey_class( $class, $self->params );
 			}
+=cut
 
+			my $o = $self->new_frey_class( $class, $self->params );
 			$o->depends if $o->can('depends');
 
-			push @{ $self->status }, { qq|<a target="editor" href="/editor+$class+1">$class</a>| => $self->params };
-
-			if ( $self->run eq 'as_markup' ) {
-				warn "## using ",ref($o), "->as_markup";
-				if ( $o->can('page') ) {
-					$html = $o->page;
-				}
-				$body = $o->as_markup unless $html;
-
-				warn ">>> markup $class ",length( $html || $body ), " ", $html ? 'html' : 'body', " bytes";
-			} elsif ( $self->run eq 'as_sponge' ) {
+			if ( $self->run =~ m{as_markup} ) {
+				$html = $o->page( run => $self->run );
+			} elsif ( $self->run =~ m{as_sponge} ) {
 				$data = $o->as_sponge;
 				confess "invalid data from sponge = ", dump( $data ) unless ref($data) eq 'HASH';
 				if ( $self->format eq 'html' ) {
@@ -105,8 +104,12 @@
 					$body .= '<tr><td>' . join('</td><td>', @$_ ) . '</td></tr>' foreach @{ $data->{rows} };
 					$body .= '</table>';
 				}
-			} elsif ( $self->run eq 'as_data' ) {
-				$data = $o->as_data;
+			} elsif ( $self->run =~ m{as_data} ) {
+				$data = $o->{$self->run}();
+				warn "no data from ", $self->run;
+				$data ||= $o->as_data();
+				confess "no data for $class->" . $self->run . " from " . $self->html_dump( $data ) unless $data;
+				$self->add_status( { $self->run => $data } );
 			} else {
 				$body = $self->error( "IGNORE: $class ", $o->dump );
 			}
@@ -114,28 +117,30 @@
 			if ( defined $data ) {
 				$html .= to_json( $data ) if $self->format =~ m{js(on)?};
 				$html .= Dump( $data )    if $self->format =~ m{ya?ml};
-				push @{ $self->status }, { 'data' => $data };
 			}
 			if ( ! $html ) {
-				$body .= Frey::View::Dumper->new( data => $data )->as_markup;
+				$body  = Frey::View::Dumper->new( data => $body )->as_markup if ref $body;
+				$body .= Frey::View::Dumper->new( data => $data )->as_markup if defined $data;
 			}
 
-			# override our status with one from object
-			eval { 
-				$self->status( $o->status );
-			};
-			warn "can't override status: $@" if $@;
-		};
-
+			$self->title( $class );
 
-		if ( ref($body) eq 'HASH' ) {
-			$html = $self->page( %$body );
-		} elsif ( $body && ! $html ) {
-			$html = $self->page( title => $self->class . ' run', body => $body );
+			$html = $o->page( body => $body ) if $body && !$html;
+	
+			confess "no html output for $class ", $o->dump unless defined $html;
 		};
+
 	};
 
-	$html = $self->page( title => $self->class, body => $self->error( $@ ) ) if $@;
+	$self->status_parts;
+
+	if ( $@ ) {
+		my $o = Frey->new;
+		Frey::Web->meta->apply( $o );
+		$html = $o->page( body => $self->error( $@ ) );
+	}
+
+	warn $self->class, " produced ", length($html), " bytes";
 
 	return $html;
 }