--- trunk/lib/Frey/Run.pm 2008/11/28 13:16:47 581 +++ trunk/lib/Frey/Run.pm 2008/11/28 16:39:37 591 @@ -65,27 +65,33 @@ my $class = $self->class; $self->load_class( $class ); - if ( $self->params_form ) { - $html = $self->page; + if ( my $form = $self->params_form ) { + $html = $self->page( body => $form ); warn "got required params form for $class ", $self->run, " format: ", $self->format; } else { $self->usage->{ $class }++; +=begin remove my $o; my ( $meta, $is_role, $instance ) = $self->class_meta( $class ); if ( $is_role ) { $o = $instance; + if ( $o->can('add_status') ) { + $self->TODO("missing add_status in $o"); + Frey::Web->meta->apply( $o ); + warn "# apply Frey::Web to $class instance $o"; + } } else { $o = $self->new_frey_class( $class, $self->params ); } +=cut + my $o = $self->new_frey_class( $class, $self->params ); $o->depends if $o->can('depends'); - $o->add_status( { $self->editor( $class ) => $self->params } ); - if ( $self->run =~ m{as_markup} ) { - $html = $o->page; + $html = $o->page( run => $self->run ); } elsif ( $self->run =~ m{as_sponge} ) { $data = $o->as_sponge; confess "invalid data from sponge = ", dump( $data ) unless ref($data) eq 'HASH'; @@ -99,7 +105,11 @@ $body .= ''; } } elsif ( $self->run =~ m{as_data} ) { - $data = $o->as_data; + $data = $o->{$self->run}(); + warn "no data from ", $self->run; + $data ||= $o->as_data(); + confess "no data for $class->" . $self->run . " from " . $self->html_dump( $data ) unless $data; + $self->add_status( { $self->run => $data } ); } else { $body = $self->error( "IGNORE: $class ", $o->dump ); } @@ -107,7 +117,6 @@ if ( defined $data ) { $html .= to_json( $data ) if $self->format =~ m{js(on)?}; $html .= Dump( $data ) if $self->format =~ m{ya?ml}; - $self->add_status( { 'data' => $data } ); } if ( ! $html ) { $body = Frey::View::Dumper->new( data => $body )->as_markup if ref $body; @@ -117,13 +126,19 @@ $self->title( $class ); $html = $o->page( body => $body ) if $body && !$html; + + confess "no html output for $class ", $o->dump unless defined $html; }; }; $self->status_parts; - $html = $self->error( $@ ) if $@; + if ( $@ ) { + my $o = Frey->new; + Frey::Web->meta->apply( $o ); + $html = $o->page( body => $self->error( $@ ) ); + } warn $self->class, " produced ", length($html), " bytes";