--- trunk/lib/Frey/Introspect.pm	2008/11/17 19:08:31	381
+++ trunk/lib/Frey/Introspect.pm	2008/11/19 17:05:59	458
@@ -103,34 +103,7 @@
 	return $out;
 }
 
-=head2 methods
-
-  my @methods = $o->methods;
-
-=cut
-
-sub methods {
-	my $self = shift;
-
-	my ( $meta, $is_role ) = $self->class_meta;
-
-	my $attr;
-	$attr->{$_}++ foreach $meta->get_attribute_list;
-	my @methods = grep { ! defined($attr->{$_}) } $meta->get_method_list;
-	warn "# methods = ",dump( @methods ) if $self->debug;
-
-	return sort @methods;
-}
-
-=head1 OUTPUT GENERATION
-
-=head2 markup
-
-  $o->markup;
-
-=cut
-
-sub markup {
+sub as_markup {
 	my ( $self ) = @_;
 
 	$self->add_head( 'static/introspect.css' );
@@ -181,24 +154,24 @@
 			$name .= qq|<sup title="$role_name">$nr</sup>|;
 		}
 		qq|<td class="m">$name</td>|
-	} $self->methods;
+	} $self->class_methods( $class );
 
 	my @attributes;
 	if ( $meta->get_attribute_list ) {
-	@attributes = map {
+		@attributes = map {
 			my $name = $_;
 			my $attr = $meta->get_attribute($name);
-			warn "## ref attr: ",ref( $attr );
+			confess "$class attribute $name isn't blessed ",dump( $attr ) unless blessed $attr;
+			warn "## attr $name ref ",ref( $attr ) if $self->debug;
 			my ( $before, $title, $after ) = ( '', '', '' );
-			( $before, $title, $after ) = ( '<b>', ' title="required"', '</b>' ) if $attr->is_required;
-warn $attr->dump(3);
+			( $before, $title, $after ) = ( '<b>', ' title="required"', '</b>' ) if $attr->can('is_required') && $attr->is_required;
 			foreach my $check ( qw/has_type_constraint has_handles is_weak_ref is_required is_lazy should_coerce should_auto_deref has_default has_trigger has_documentation has_applied_traits/ ) {
 				my $getter;
 				
 				$getter = $check;
 				$getter =~ s/^has_//;
 				
-				if ( $attr->$check ) {
+				if ( $attr->can($check) && $attr->$check ) {
 					if ( $getter eq $check ) {
 						$after .= "$check";
 					} else {
@@ -210,7 +183,7 @@
 				}
 				$after .= ' ';
 			}
-			my $type = $attr->has_type_constraint ? $attr->type_constraint->name : '';
+			my $type = $attr->can('has_type_constraint') && $attr->has_type_constraint ? $attr->type_constraint->name : '';
 
 			if ( $role_attribute->{$name} ) {
 				my ( $role_name, $nr ) = each %{ $role_attribute->{$name} };
@@ -218,7 +191,7 @@
 			}
 
 			qq|<td class="a">$before $name</td><td class="t">$type</td><td>$after</td>|
-		} sort $meta->get_attribute_list
+		} $meta->get_attribute_list
 	}
 
 	my $table = qq|<table class="frey-introspect"><tr><th class="m">Methods</th><th class="a">Attributes</th><th>Type</th><th class="p">Properties</th></tr>|;
@@ -230,14 +203,15 @@
 	}
 	$table .= qq|</table>|;
 
-	my $pod = Frey::Pod->new( class => $class )->markup;
+	my $pod = Frey::Pod->new( class => $class )->as_markup;
 	$pod = $pod->{body} if ref($pod);
 
-	my $Document = PPI::Document->new( $self->class_path( $class ) );
+	my $path = $self->class_path( $class );
+	my $Document = PPI::Document->new( $path );
 
 	# Create a reusable syntax highlighter
 	my $Highlight = PPI::HTML->new(
-#		line_numbers => 1,
+		line_numbers => 1,
 #		page => 1,
 #		colors => {
 #			line_number => '#CCCCCC',
@@ -248,26 +222,30 @@
 	# Spit out the HTML
 	my $source = $Highlight->html( $Document );
 
+	$source =~ s{(<span.*?line_number.*>\s*)(\d+)(:\s*</span>)}{$1<a target="editor" href="/editor+$path+$2">$2</a>$3}g;
+
+	# strip page html
 #	$source =~ s{^.*<body[^>]+>}{}s;
 #	$source =~ s{</body.*$}{}s;
 
-	use Frey::Run;
-	my $runnable = join("\n", map { qq|<a href="/$class/$_">$_</a>| } grep { $class->can($_) } Frey::Run->runnable );
+
+	my $runnable = join("\n",
+		map {
+			qq|<a href="/$class/$_">$_</a>|
+		} $self->class_runnable( $class )
+	);
 	$runnable = " runnable: $runnable" if $runnable;
 
-	my $html = {
-		title => $class,
-		body => join("\n",
-			qq|<h1>$class</h1>|,
-			qq|<div class="frey-introspect">$superclasses\n$roles\n$runnable\n|,
-			$pod    ? qq|<a class="frey-skip" href="#___top" title="Skip to POD"    >pod</a>|    : '',
-			$source ? qq|<a class="frey-skip" href="#source" title="Skip to source" >source</a>| : '',
-			qq|$table\n$pod\n</div>\n|,
-			qq|<h1>Source</h1><a name="source"></a><div class="frey-source">$source</div>|,
-		),
-	};
+	$self->title( $class );
 
-	return $html;
+	return join("\n",
+		qq|<h1>$class</h1>|,
+		qq|<div class="frey-introspect">$superclasses\n$roles\n$runnable\n|,
+		$pod    ? qq|<a class="frey-skip" href="#___top" title="Skip to POD"    >pod</a>|    : '',
+		$source ? qq|<a class="frey-skip" href="#source" title="Skip to source" >source</a>| : '',
+		qq|$table\n$pod\n</div>\n|,
+		qq|<h1>Source</h1><a name="source"></a><div class="frey-source">$source</div>|,
+	);
 }
 
 =head1 SEE ALSO