--- trunk/lib/Frey/Action.pm	2008/12/06 00:57:49	734
+++ trunk/lib/Frey/Action.pm	2009/01/09 21:30:06	975
@@ -12,6 +12,11 @@
 Invoke any L<Frey> object creating html for with various default parameters
 if not supplied at invocation.
 
+You can force rendering of fields if you define C<render_attribute> sub with
+desired rendering as in:
+
+  sub render_pipe { 'radio' }
+
 =cut
 
 has 'class' => (
@@ -26,15 +31,24 @@
 	default => sub { {} },
 );
 
+has 'input_step_size' => (
+	documentation => 'Resize input fields by this step',
+	is => 'rw',
+	isa => 'Int',
+#	required => 1,
+	default => 20,
+);
+
 =head2 required
 
   my @required_attributes = $self->required;
   my $required_attributes = $self->required;
+  my $required_hash       = $self->required('as_hash');
 
 =cut
 
 sub required {
-	my ( $self ) = @_;
+	my ($self,$param) = @_;
 	$self->load_class( $self->class );
 
 	my @required = 
@@ -48,7 +62,14 @@
 			blessed $attr && $attr->is_required && $attr;
 		} $self->class->meta->get_attribute_list;
 
-	warn "## required = ",dump( map { $_->name } @required ), " for ", $self->class if @required && $self->debug;
+	@required = map { $_->name } @required;
+	warn "## required = ",dump( @required ), " for ", $self->class if @required && $self->debug;
+
+	if ( $param eq 'as_hash' ) {
+		my $hash;
+		map { $hash->{$_}++ } @required;
+		return $hash;
+	}
 	return @required if wantarray;
 	return \@required;
 }
@@ -68,7 +89,7 @@
 	my $a;
 	my @attrs = @{ $self->attribute_order };
 	@attrs = map {  $a->{$_}++; $_ } @attrs;
-	push @attrs, $_ foreach grep { ! $a->{$_} } map { $_->name } @{ $self->required };
+	push @attrs, $_ foreach grep { ! $a->{$_} } @{ $self->required };
 	warn "# attributes = ",dump( @attrs ) if $self->debug;
 	return @attrs if wantarray;
 	return \@attrs;
@@ -83,13 +104,13 @@
 
 sub params_form {
 	my ( $self ) = @_;
-	my @required = $self->required;
-	if ( ! @required ) {
+	my $required = $self->required('as_hash');
+	if ( $required ) {
+		warn $self->class, " required params ", dump( keys %$required ) if $self->debug;
+	} else {
 		warn "all params available ", dump( $self->params ), " not creating form" if $self->debug;
 		return (undef,$self->params) if wantarray;
 		return;
-	} else {
-		warn $self->class, " required params ", map { $_->dump(2) } @required if $self->debug;
 	}
 
 	my $class = $self->class;
@@ -103,29 +124,75 @@
 	warn "# $class config = ",dump( $params_config ) if $self->debug;
 
 	my $form;
+	my $form_id = $class;
+	$form_id =~ s{\W+}{_}g;
 
 	sub select_values {
 		my ( $name, $attr_type, $values ) = @_;
 
-		if ( $#$values > 3 ) {
+		$attr_type ||= '?' and warn "$name doesn't have attr_type";
+
+		my $max_value_len = 0;
+		my @values;
+		my $html = '';
+
+		foreach ( @$values ) {
+			my $v = ref($_) eq 'HASH' ? $_->{$name} : $_;
+			warn "## value '$v'";
+			push @values, $v;
+			$max_value_len = length($v) if length($v) > $max_value_len;
+		}
+
+		warn "# max_value_len: $max_value_len";
+		my $render = eval $class . '->render_' . $name;
+		warn "## render $@";
+
+		if ( $#values > 3 && $render !~ m{radio} ) {
 			my $options = join("\n",
 				map {
-					my $v = ref($_) eq 'HASH' ? $_->{$name} : $_;
-					qq|<option value="$v">$v</option>| if $v;
-				} @$values
+					qq|<option value="$_">$_</option>|;
+				} @values
 			);
-			qq|<select title="$attr_type" name="$name">$options</select>| if $options;
+			# onchange="alert(this.options[this.selectedIndex].value);"
+			$html = qq|
+				<select title="$attr_type" name="$name">
+				$options
+				</select>
+			| if $options;
 		} else {
-			my $radio = join("\n",
-				map {
-					my $v = ref($_) eq 'HASH' ? $_->{$name} : $_;
-					qq|<input type="radio" name="$name" value="$v" title="$attr_type"><span style="float: left; padding-right: 2em;">$v</span>|;
-				} @$values
+			my $delimiter = $max_value_len > $self->input_step_size ? qq|<br>| : '';
+			my $radio =
+#				$delimiter .
+				join("\n",
+				map { strip(qq|
+						<span title="$attr_type">
+						<input type="radio" name="$name" value="$_">
+						$_
+						</span>
+						$delimiter
+				|) } @values
 			);
-			qq|<div>$radio</div>|;
+			if ( $radio ) {
+				
+				my $size = int( $max_value_len / $self->input_step_size ) + 1;
+				$size = 5 if $size > 5;
+				$size *= $self->input_step_size;
+				$radio .= qq|
+					<span>
+					<input type="radio" name="$name" value=" " onclick="document.getElementById('new-$name').focus();" >
+					<input type="text" name="new-$name" id="new-$name" onchange="clear_radio('$form_id','$name'); this.disable = false;" onblur="this.disable = true;" title="enter new value" size="$size">
+					</span>
+				|;
+			}
+			$html = qq|<div style="display: block;">$radio</div>|;
 		}
+
+		return
+#			qq|<input type="text" name="$name">| .
+			$html
 	}
 
+
 	foreach my $checkbox ( split(/\s+/, $default->{'frey-checkboxes'} ) ) {
 		next if defined $default->{ $checkbox };
 
@@ -136,17 +203,11 @@
 
 	my @checkboxes;
 
-	my $skip_prefix;
-	if ( $self->class->can('action') ) {
-		my $action = eval $self->class . '->action';
-		$skip_prefix->{$_}++ foreach eval $self->class .'->action_order';
-		warn "# skip_prefix = ", $self->dump( $skip_prefix );
-	}
-
 	my $label_width = 1; # minimum
 
 	foreach my $name (
 		grep {
+			die "$_ doesn't have meta" unless $class->can('meta');
 			! $class->meta->get_attribute($_)->is_lazy
 			&& ! defined $default->{$_}
 			&& ! m{^_} # skip _private
@@ -166,7 +227,7 @@
 			$attr->has_default        ? $attr->default( $name ) :
 			'';
 
-		if ( ref($params_config) eq 'HASH' ) {
+		if ( ref($params_config) eq 'HASH' && defined $params_config->{$name} ) {
 			$value = $params_config->{$name};
 		} elsif ( ref($params_config) eq 'ARRAY' ) {
 			$value_html = select_values( $name, $attr_type, $params_config );
@@ -180,7 +241,7 @@
 			push @checkboxes, $name;
 		} elsif ( ! defined $value ) {
 			$value_html = qq|<tt id="$name">undef</tt><!-- $name = undef -->|; # FIXME if $self->debug
-		} elsif ( $attr_type !~ m{^(Str|Int)$} || $value =~ $Frey::Web::re_html ) {
+		} elsif ( $attr_type !~ m{^(Str|Int)$} || $value =~ $Frey::Web::re_html || $name =~ m{text} ) {
 			$value_html = qq|<textarea name="$name" title="$attr_type">$value</textarea>|;
 		}
 
@@ -188,15 +249,24 @@
 
 		$default->{$name} = $value unless defined $default->{$name};
 
-		$value_html = qq|<input type="$type" name="$name" title="$attr_type" value="$value">| unless $value_html;
+		my $size = ( int( length($value) / $self->input_step_size ) + 1 ) * $self->input_step_size;
+		$value_html = qq|<input type="$type" name="$name" title="$attr_type" value="$value" size="$size">| unless $value_html;
 
 #		warn "# required $name ", $class->meta->get_attribute( $name )->dump( 2 );
+
+		$label_title .= qq| class="required"| if $required->{$name};
+		$label =~ s/_/ /g;
+
 		$form .= qq|<label for="$name"$label_title>$label</label>$value_html<br>|;
 		my $ll = length($label);
 		$label_width = $ll if $ll > $label_width;
 	}
 	$form .= qq|<input type="hidden" name="frey-checkboxes" value="| . join(' ', @checkboxes) . qq|">| if @checkboxes;
 
+	$label_width += 2; # XXX padding left+right em
+
+	$self->add_js('static/Frey/Action.js');
+
 	$self->add_css(qq|
 		label,input {
 			display: block;
@@ -204,10 +274,20 @@
 			margin-bottom: 10px;
 		}
 
+		input:focus {
+			border-color: #cc0;
+			background: #ffc;
+		}
+
 		label {
 			text-align: right;
 			width: ${label_width}ex;
-			padding-right: 20px;
+			padding-right: 1ex;
+			white-space: nowrap;
+		}
+
+		label.required {
+			font-weight: bold;
 		}
 
 		br {
@@ -222,7 +302,7 @@
 
 	$html = qq|
 		<h1>$class params</h1>
-		<form method="post">
+		<form name="$form_id" id="$form_id" method="post">
 		$form
 		<input type="submit" value="Run $class">
 		</form>