--- branches/no-pager/lib/Frey/Action.pm	2008/12/06 14:35:15	737
+++ branches/no-pager/lib/Frey/Action.pm	2008/12/06 15:29:10	738
@@ -36,6 +36,7 @@
 sub required {
 	my ( $self ) = @_;
 	$self->load_class( $self->class );
+
 	my @required = 
 		grep {
 			defined $_ && $_->can('name') &&
@@ -97,21 +98,32 @@
 
 	my $default = clone $self->params; # XXX we really don't want to modify params!
 
-	my $config_params = {};
-	$config_params = $self->config($class);
-	warn "# $class config = ",dump( $config_params ) if $self->debug;
+	my $params_config = {};
+	$params_config = $self->config($class);
+	warn "# $class config = ",dump( $params_config ) if $self->debug;
 
 	my $form;
 
 	sub select_values {
 		my ( $name, $attr_type, $values ) = @_;
-		my $options = join("\n",
-			map {
-				my $v = ref($_) eq 'HASH' ? $_->{$name} : $_;
-				qq|<option value="$v">$v</option>| if $v;
-			} @$values
-		);
-		qq|<select title="$attr_type" name="$name">$options</select>| if $options;
+
+		if ( $#$values > 3 ) {
+			my $options = join("\n",
+				map {
+					my $v = ref($_) eq 'HASH' ? $_->{$name} : $_;
+					qq|<option value="$v">$v</option>| if $v;
+				} @$values
+			);
+			qq|<select title="$attr_type" name="$name">$options</select>| if $options;
+		} else {
+			my $radio = join("\n",
+				map {
+					my $v = ref($_) eq 'HASH' ? $_->{$name} : $_;
+					qq|<input type="radio" name="$name" value="$v" title="$attr_type"><span style="float: left; padding-right: 2em;">$v</span>|;
+				} @$values
+			);
+			qq|<div>$radio</div>|;
+		}
 	}
 
 	foreach my $checkbox ( split(/\s+/, $default->{'frey-checkboxes'} ) ) {
@@ -124,10 +136,20 @@
 
 	my @checkboxes;
 
+	my $skip_prefix;
+	if ( $self->class->can('action') ) {
+		my $action = eval $self->class . '->action';
+		$skip_prefix->{$_}++ foreach eval $self->class .'->action_order';
+		warn "# skip_prefix = ", $self->dump( $skip_prefix );
+	}
+
+	my $label_width = 1; # minimum
+
 	foreach my $name (
 		grep {
 			! $class->meta->get_attribute($_)->is_lazy
 			&& ! defined $default->{$_}
+			&& ! m{^_} # skip _private
 		} $self->attributes
 	) {
 		my $attr_type = '';
@@ -144,22 +166,24 @@
 			$attr->has_default        ? $attr->default( $name ) :
 			'';
 
-		if ( ref($config_params) eq 'HASH' ) {
-			$value = $config_params->{$name};
-		} elsif ( ref($config_params) eq 'ARRAY' ) {
-			$value_html = select_values( $name, $attr_type, $config_params );
-			$default->{$name} = $config_params->[0]->{$name};
+		if ( ref($params_config) eq 'HASH' ) {
+			$value = $params_config->{$name};
+		} elsif ( ref($params_config) eq 'ARRAY' ) {
+			$value_html = select_values( $name, $attr_type, $params_config );
+			$default->{$name} = $params_config->[0]->{$name};
 		} elsif ( $attr->has_type_constraint && $attr->type_constraint->can('values') ) {
-				$value_html = select_values( $name, $attr_type, $attr->type_constraint->values );
+			$value_html = select_values( $name, $attr_type, $attr->type_constraint->values );
 		} elsif ( $attr_type =~ m{^Bool} ) {
-				my $suffix = '';
-				$suffix = ' checked' if $value;
-				$value_html = qq|<input type="checkbox" name="$name" title="$attr_type" value="$value"$suffix>|;
-				push @checkboxes, $name;
-		} elsif ( $attr_type !~ m{^(Str|Int)$} ) {
-				$value_html = qq|<textarea name="$name" title="$attr_type">$value</textarea>|;
+			my $suffix = '';
+			$suffix = ' checked' if $value;
+			$value_html = qq|<input type="checkbox" name="$name" title="$attr_type" value="$value"$suffix>|;
+			push @checkboxes, $name;
+		} elsif ( ! defined $value ) {
+			$value_html = qq|<tt id="$name">undef</tt><!-- $name = undef -->|; # FIXME if $self->debug
+		} elsif ( $attr_type !~ m{^(Str|Int)$} || $value =~ $Frey::Web::re_html ) {
+			$value_html = qq|<textarea name="$name" title="$attr_type">$value</textarea>|;
 		}
-		
+
 		$label_title = qq| title="| . $attr->documentation . qq|"| if $attr->has_documentation;
 
 		$default->{$name} = $value unless defined $default->{$name};
@@ -167,12 +191,35 @@
 		$value_html = qq|<input type="$type" name="$name" title="$attr_type" value="$value">| unless $value_html;
 
 #		warn "# required $name ", $class->meta->get_attribute( $name )->dump( 2 );
-		$form .= qq|<label for="$name"$label_title>$label</label>| . $value_html;
+		$form .= qq|<label for="$name"$label_title>$label</label>$value_html<br>|;
+		my $ll = length($label);
+		$label_width = $ll if $ll > $label_width;
 	}
 	$form .= qq|<input type="hidden" name="frey-checkboxes" value="| . join(' ', @checkboxes) . qq|">| if @checkboxes;
 
+	$self->add_css(qq|
+		label,input {
+			display: block;
+			float: left;
+			margin-bottom: 10px;
+		}
+
+		label {
+			text-align: right;
+			width: ${label_width}ex;
+			padding-right: 20px;
+		}
+
+		br {
+			clear: left;
+		}
+	|);
+
 	my $html;
 
+	# http://www.quirksmode.org/oddsandends/forms.html
+#	$form =~ s{<([^>]+)(name=")([^"]+)(")([^>]*)>}{<$1$2$3$4 id="$3" $5}gs;
+
 	$html = qq|
 		<h1>$class params</h1>
 		<form method="post">
@@ -184,8 +231,8 @@
 	$self->add_status({
 		$self->class => {
 			params  => $self->params,
-			config_params  => $config_params,
-			default => $default
+			params_config  => $params_config,
+			default => $default,
 		},
 	});
 
@@ -193,4 +240,10 @@
 	return $html;
 }
 
+=head1 SEE ALSO
+
+L<http://www.quirksmode.org/css/forms.html> for info on CSS2 forms
+
+=cut
+
 1;